Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache storage overflow #88

Closed
Avariya opened this issue Jul 19, 2017 · 1 comment
Closed

Cache storage overflow #88

Avariya opened this issue Jul 19, 2017 · 1 comment

Comments

@Avariya
Copy link

Avariya commented Jul 19, 2017

Problem:
If you are using Etag or Last-Modified validation models - it is a big risk of cache overflow.
E.g.: you are updating response every second and as a result update Last-Modified header every second.
The record will be added to cache storage and never will be removed as it has no TTL.
As Etag header is new - record with a new key will be created.

Probable solution:
Remove headers mentioned above from response headers before generating a cache key. E.g. at PrivateCacheStrategy:123

@Avariya Avariya changed the title Ttl support for cache records Cache storage overflow Jul 19, 2017
@Avariya
Copy link
Author

Avariya commented Jul 19, 2017

Looks like it is not a reason.
Only vary headers are in list

@Avariya Avariya closed this as completed Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant