Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate subclasses of SingleTypeAdapter that wish to implement android.widget.Filterable #3

Closed
wants to merge 2 commits into from

Conversation

jondwillis
Copy link
Contributor

This exposes a new method, getItems() as protected.
Primarily, this allows subclasses to implement android.widget.Filterable more cleanly. The subclass can cache a list of all items. Please let me know if I'm missing something and there's a better way to do this.

I didn't apply this change to any other adapters.

Primarily, this allows subclasses to implement android.widget.Filterable cleanly
@kevinsawicki
Copy link
Owner

Looks like the commit currently doesn't compile since imports need to be added for List and Arrays.

I'm totally on board with adding this though.

@jondwillis
Copy link
Contributor Author

I updated the pull request with the missing imports - that is what I get for editing it using GitHub's interface. I'm not sure how performant getItems() is right now, but it seems to be fine in my limited usage.

It also appears as though your Travis build script is missing ANDROID_HOME.

@kevinsawicki
Copy link
Owner

Thanks, I've merged this into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants