Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing p from the break screen breaks things #25

Closed
aThorp96 opened this issue Apr 21, 2020 · 6 comments
Closed

Pressing p from the break screen breaks things #25

aThorp96 opened this issue Apr 21, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@aThorp96
Copy link

aThorp96 commented Apr 21, 2020

Accidentally pressing p from the break screen seems to cause some sort of lock to occur. The UI accepts no input or interrupts and I've only been able to kill it by closing the tmux pane pomo is running in. I haven't dug in too deep, but I think this might be fixable by adding some checks to TaskRunner.Pause().

@aThorp96
Copy link
Author

An alternative, and perhaps less computationally expensive, fix for this would be to refactor runner to run using a state machine and have the run loop operate off of sentinel values sent through a single channel of ints

@aThorp96
Copy link
Author

Just realized the runner is being redesigned in the develop branch. I did confirm develop currently has the same bug though.

@kevinschoon
Copy link
Owner

@aThorp96 I agree about the state machine, will leave this open and address it in the next release.

@kevinschoon kevinschoon added the bug Something isn't working label Apr 29, 2020
@strogiyotec
Copy link
Contributor

@kevinschoon are you working on it right now ? I have the same problem now , could fix it in free time

@Poroing
Copy link

Poroing commented Jun 4, 2021

Is anyone working on this issue ? I could try to learn GO and fix this.

@kevinschoon
Copy link
Owner

Added a fix for this in 1b32119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants