Skip to content

Commit

Permalink
net/virtio: remove remaining simple Tx related stuff
Browse files Browse the repository at this point in the history
[ upstream commit 1d2aa48 ]

The simple Tx path in virtio has been removed in below commit.
This patch removes an undefined function declaration of simple
Tx and all related descriptions in the doc.

Fixes: 57f8189 ("net/virtio: remove simple Tx path")

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
  • Loading branch information
Tiwei Bie authored and kevintraynor committed Nov 22, 2019
1 parent 5d24e09 commit 038f992
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
15 changes: 2 additions & 13 deletions doc/guides/nics/virtio.rst
Expand Up @@ -201,7 +201,7 @@ The packet transmission flow is:
Virtio PMD Rx/Tx Callbacks
--------------------------

Virtio driver has 4 Rx callbacks and 3 Tx callbacks.
Virtio driver has 4 Rx callbacks and 2 Tx callbacks.

Rx callbacks:

Expand All @@ -223,9 +223,6 @@ Tx callbacks:
#. ``virtio_xmit_pkts``:
Regular version.

#. ``virtio_xmit_pkts_simple``:
Vector version fixes the available ring indexes to optimize performance.

#. ``virtio_xmit_pkts_inorder``:
In-order version.

Expand All @@ -239,25 +236,17 @@ By default, the non-vector callbacks are used:

Vector callbacks will be used when:

* ``txmode.offloads`` is set to ``0x0``, which implies:

* Single segment is specified.

* No offload support is needed.

* Mergeable Rx buffers is disabled.

The corresponding callbacks are:

* For Rx: ``virtio_recv_pkts_vec``.

* For Tx: ``virtio_xmit_pkts_simple``.


Example of using the vector version of the virtio poll mode driver in
``testpmd``::

testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1
testpmd -l 0-2 -n 4 -- -i --rxq=1 --txq=1 --nb-cores=1

In-order callbacks only work on simulated virtio user vdev.

Expand Down
3 changes: 0 additions & 3 deletions drivers/net/virtio/virtio_ethdev.h
Expand Up @@ -94,9 +94,6 @@ uint16_t virtio_xmit_pkts_inorder(void *tx_queue, struct rte_mbuf **tx_pkts,
uint16_t virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
uint16_t nb_pkts);

uint16_t virtio_xmit_pkts_simple(void *tx_queue, struct rte_mbuf **tx_pkts,
uint16_t nb_pkts);

int eth_virtio_dev_init(struct rte_eth_dev *eth_dev);

void virtio_interrupt_handler(void *param);
Expand Down

0 comments on commit 038f992

Please sign in to comment.