Skip to content

Commit

Permalink
net/bonding: fix out of bound access in LACP mode
Browse files Browse the repository at this point in the history 
[ upstream commit 8ff0003 ]

We'd better consolidate the fast queue and the normal tx burst functions
under a common inline wrapper for maintenance.

But looking closer at the bufs_slave_port_idxs[] mapping array in those
tx burst functions, its size is invalid since up to nb_bufs are handled
here.
A previous patch [1] fixed this issue for balance tx burst function
without mentioning it.

802.3ad and balance modes are functionally equivalent on transmit.
The only difference is on the slave id distribution.
Add an additional inline wrapper to consolidate even more and fix this
issue.

[1]: https://git.dpdk.org/dpdk/commit/?id=c5224f623431

Fixes: 0915078 ("net/bonding: burst mode hash calculation")

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Chas Williams <chas3@att.com>
  • Loading branch information
@david-marchand @kevintraynor
david-marchand authored and kevintraynor committed Nov 21, 2019
1 parent 7df88d5 commit 349544c
Showing 1 changed file with 51 additions and 162 deletions.
213 changes: 51 additions & 162 deletions drivers/net/bonding/rte_eth_bond_pmd.c
View file
Expand Up @@ -2,6 +2,7 @@
* Copyright(c) 2010-2017 Intel Corporation
*/
#include <stdlib.h>
#include <stdbool.h>
#include <netinet/in.h>

#include <rte_mbuf.h>
Expand Down Expand Up @@ -290,97 +291,6 @@ bond_ethdev_rx_burst_8023ad_fast_queue(void *queue, struct rte_mbuf **bufs,
return num_rx_total;
}

static uint16_t
bond_ethdev_tx_burst_8023ad_fast_queue(void *queue, struct rte_mbuf **bufs,
uint16_t nb_bufs)
{
struct bond_tx_queue *bd_tx_q = (struct bond_tx_queue *)queue;
struct bond_dev_private *internals = bd_tx_q->dev_private;

uint16_t slave_port_ids[RTE_MAX_ETHPORTS];
uint16_t slave_count;

uint16_t dist_slave_port_ids[RTE_MAX_ETHPORTS];
uint16_t dist_slave_count;

/* 2-D array to sort mbufs for transmission on each slave into */
struct rte_mbuf *slave_bufs[RTE_MAX_ETHPORTS][nb_bufs];
/* Number of mbufs for transmission on each slave */
uint16_t slave_nb_bufs[RTE_MAX_ETHPORTS] = { 0 };
/* Mapping array generated by hash function to map mbufs to slaves */
uint16_t bufs_slave_port_idxs[RTE_MAX_ETHPORTS] = { 0 };

uint16_t slave_tx_count;
uint16_t total_tx_count = 0, total_tx_fail_count = 0;

uint16_t i;

if (unlikely(nb_bufs == 0))
return 0;

/* Copy slave list to protect against slave up/down changes during tx
* bursting */
slave_count = internals->active_slave_count;
if (unlikely(slave_count < 1))
return 0;

memcpy(slave_port_ids, internals->active_slaves,
sizeof(slave_port_ids[0]) * slave_count);


dist_slave_count = 0;
for (i = 0; i < slave_count; i++) {
struct port *port = &bond_mode_8023ad_ports[slave_port_ids[i]];

if (ACTOR_STATE(port, DISTRIBUTING))
dist_slave_port_ids[dist_slave_count++] =
slave_port_ids[i];
}

if (unlikely(dist_slave_count < 1))
return 0;

/*
* Populate slaves mbuf with the packets which are to be sent on it
* selecting output slave using hash based on xmit policy
*/
internals->burst_xmit_hash(bufs, nb_bufs, dist_slave_count,
bufs_slave_port_idxs);

for (i = 0; i < nb_bufs; i++) {
/* Populate slave mbuf arrays with mbufs for that slave. */
uint16_t slave_idx = bufs_slave_port_idxs[i];

slave_bufs[slave_idx][slave_nb_bufs[slave_idx]++] = bufs[i];
}


/* Send packet burst on each slave device */
for (i = 0; i < dist_slave_count; i++) {
if (slave_nb_bufs[i] == 0)
continue;

slave_tx_count = rte_eth_tx_burst(dist_slave_port_ids[i],
bd_tx_q->queue_id, slave_bufs[i],
slave_nb_bufs[i]);

total_tx_count += slave_tx_count;

/* If tx burst fails move packets to end of bufs */
if (unlikely(slave_tx_count < slave_nb_bufs[i])) {
int slave_tx_fail_count = slave_nb_bufs[i] -
slave_tx_count;
total_tx_fail_count += slave_tx_fail_count;
memcpy(&bufs[nb_bufs - total_tx_fail_count],
&slave_bufs[i][slave_tx_count],
slave_tx_fail_count * sizeof(bufs[0]));
}
}

return total_tx_count;
}


static uint16_t
bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
uint16_t nb_pkts)
Expand Down Expand Up @@ -1196,16 +1106,13 @@ bond_ethdev_tx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
return num_tx_total;
}

static uint16_t
bond_ethdev_tx_burst_balance(void *queue, struct rte_mbuf **bufs,
uint16_t nb_bufs)
static inline uint16_t
tx_burst_balance(void *queue, struct rte_mbuf **bufs, uint16_t nb_bufs,
uint16_t *slave_port_ids, uint16_t slave_count)
{
struct bond_tx_queue *bd_tx_q = (struct bond_tx_queue *)queue;
struct bond_dev_private *internals = bd_tx_q->dev_private;

uint16_t slave_port_ids[RTE_MAX_ETHPORTS];
uint16_t slave_count;

/* Array to sort mbufs for transmission on each slave into */
struct rte_mbuf *slave_bufs[RTE_MAX_ETHPORTS][nb_bufs];
/* Number of mbufs for transmission on each slave */
Expand All @@ -1218,18 +1125,6 @@ bond_ethdev_tx_burst_balance(void *queue, struct rte_mbuf **bufs,

uint16_t i;

if (unlikely(nb_bufs == 0))
return 0;

/* Copy slave list to protect against slave up/down changes during tx
* bursting */
slave_count = internals->active_slave_count;
if (unlikely(slave_count < 1))
return 0;

memcpy(slave_port_ids, internals->active_slaves,
sizeof(slave_port_ids[0]) * slave_count);

/*
* Populate slaves mbuf with the packets which are to be sent on it
* selecting output slave using hash based on xmit policy
Expand Down Expand Up @@ -1270,7 +1165,7 @@ bond_ethdev_tx_burst_balance(void *queue, struct rte_mbuf **bufs,
}

static uint16_t
bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
bond_ethdev_tx_burst_balance(void *queue, struct rte_mbuf **bufs,
uint16_t nb_bufs)
{
struct bond_tx_queue *bd_tx_q = (struct bond_tx_queue *)queue;
Expand All @@ -1279,18 +1174,36 @@ bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
uint16_t slave_port_ids[RTE_MAX_ETHPORTS];
uint16_t slave_count;

if (unlikely(nb_bufs == 0))
return 0;

/* Copy slave list to protect against slave up/down changes during tx
* bursting
*/
slave_count = internals->active_slave_count;
if (unlikely(slave_count < 1))
return 0;

memcpy(slave_port_ids, internals->active_slaves,
sizeof(slave_port_ids[0]) * slave_count);
return tx_burst_balance(queue, bufs, nb_bufs, slave_port_ids,
slave_count);
}

static inline uint16_t
tx_burst_8023ad(void *queue, struct rte_mbuf **bufs, uint16_t nb_bufs,
bool dedicated_txq)
{
struct bond_tx_queue *bd_tx_q = (struct bond_tx_queue *)queue;
struct bond_dev_private *internals = bd_tx_q->dev_private;

uint16_t slave_port_ids[RTE_MAX_ETHPORTS];
uint16_t slave_count;

uint16_t dist_slave_port_ids[RTE_MAX_ETHPORTS];
uint16_t dist_slave_count;

/* 2-D array to sort mbufs for transmission on each slave into */
struct rte_mbuf *slave_bufs[RTE_MAX_ETHPORTS][nb_bufs];
/* Number of mbufs for transmission on each slave */
uint16_t slave_nb_bufs[RTE_MAX_ETHPORTS] = { 0 };
/* Mapping array generated by hash function to map mbufs to slaves */
uint16_t bufs_slave_port_idxs[RTE_MAX_ETHPORTS] = { 0 };

uint16_t slave_tx_count;
uint16_t total_tx_count = 0, total_tx_fail_count = 0;

uint16_t i;

Expand All @@ -1303,6 +1216,9 @@ bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
memcpy(slave_port_ids, internals->active_slaves,
sizeof(slave_port_ids[0]) * slave_count);

if (dedicated_txq)
goto skip_tx_ring;

/* Check for LACP control packets and send if available */
for (i = 0; i < slave_count; i++) {
struct port *port = &bond_mode_8023ad_ports[slave_port_ids[i]];
Expand All @@ -1324,6 +1240,7 @@ bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
}
}

skip_tx_ring:
if (unlikely(nb_bufs == 0))
return 0;

Expand All @@ -1336,53 +1253,25 @@ bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
slave_port_ids[i];
}

if (likely(dist_slave_count > 0)) {

/*
* Populate slaves mbuf with the packets which are to be sent
* on it, selecting output slave using hash based on xmit policy
*/
internals->burst_xmit_hash(bufs, nb_bufs, dist_slave_count,
bufs_slave_port_idxs);

for (i = 0; i < nb_bufs; i++) {
/*
* Populate slave mbuf arrays with mbufs for that
* slave
*/
uint16_t slave_idx = bufs_slave_port_idxs[i];

slave_bufs[slave_idx][slave_nb_bufs[slave_idx]++] =
bufs[i];
}


/* Send packet burst on each slave device */
for (i = 0; i < dist_slave_count; i++) {
if (slave_nb_bufs[i] == 0)
continue;

slave_tx_count = rte_eth_tx_burst(
dist_slave_port_ids[i],
bd_tx_q->queue_id, slave_bufs[i],
slave_nb_bufs[i]);

total_tx_count += slave_tx_count;
if (unlikely(dist_slave_count < 1))
return 0;

/* If tx burst fails move packets to end of bufs */
if (unlikely(slave_tx_count < slave_nb_bufs[i])) {
int slave_tx_fail_count = slave_nb_bufs[i] -
slave_tx_count;
total_tx_fail_count += slave_tx_fail_count;
return tx_burst_balance(queue, bufs, nb_bufs, dist_slave_port_ids,
dist_slave_count);
}

memcpy(&bufs[nb_bufs - total_tx_fail_count],
&slave_bufs[i][slave_tx_count],
slave_tx_fail_count * sizeof(bufs[0]));
}
}
}
static uint16_t
bond_ethdev_tx_burst_8023ad(void *queue, struct rte_mbuf **bufs,
uint16_t nb_bufs)
{
return tx_burst_8023ad(queue, bufs, nb_bufs, false);
}

return total_tx_count;
static uint16_t
bond_ethdev_tx_burst_8023ad_fast_queue(void *queue, struct rte_mbuf **bufs,
uint16_t nb_bufs)
{
return tx_burst_8023ad(queue, bufs, nb_bufs, true);
}

static uint16_t
Expand Down

0 comments on commit 349544c

Please sign in to comment.