Skip to content
Browse files

usertools: replace unsafe input function

[ upstream commit 53f293c9a7833747d90b90bf33d12fe1d4f8ef1e ]

LGTM static code analysis tool reports that the function 'input' is
unsafe. Changed to use raw_input which then converts it using
ast.literal_eval() which is safe.

Fixes: d1b94da ("usertools: add client script for telemetry")

Signed-off-by: Andrius Sirvys <>
Acked-by: Kevin Laatz <>
  • Loading branch information...
Andrius Sirvys authored and kevintraynor committed Apr 8, 2019
1 parent 784e0fe commit 5636553a2ddf31e65ae51f6fe99c9a9fddd0cbf8
Showing with 7 additions and 2 deletions.
  1. +7 −2 usertools/
@@ -13,6 +13,11 @@
API_UNREG = "{\"action\":2,\"command\":\"clients\",\"data\":{\"client_path\":\""
DEFAULT_FP = "/var/run/dpdk/default_client"

raw_input # Python 2
except NameError:
raw_input = input # Python 3

class Socket:

def __init__(self):
@@ -71,7 +76,7 @@ def requestMetrics(self): # Requests metrics for given client

def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
print("\nPlease enter the number of times you'd like to continuously request Metrics:")
n_requests = int(input("\n:"))
n_requests = int(ast.literal_eval(raw_input("\n:")))
print("\033[F") #Removes the user input from screen, cleans it up
for i in range(n_requests):
@@ -86,7 +91,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
print("[3] Unregister client")

self.choice = int(input("\n:"))
self.choice = int(ast.literal_eval(raw_input("\n:")))
print("\033[F") #Removes the user input for screen, cleans it up
if self.choice == 1:

0 comments on commit 5636553

Please sign in to comment.
You can’t perform that action at this time.