Skip to content

Commit

Permalink
crypto/openssl: fix free of asymmetric crypto keys
Browse files Browse the repository at this point in the history
[ upstream commit 77411bd ]

In case big number need to be freed, data it contains should
also be cleared before especially if it is critical data like
private keys.

Fixes: 3e9d6bd ("crypto/openssl: add RSA and mod asym operations")
Cc: stable@dpdk.org

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
  • Loading branch information
arekk67 authored and kevintraynor committed Aug 27, 2019
1 parent df83217 commit 78807f9
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/crypto/openssl/rte_openssl_pmd_ops.c
Expand Up @@ -911,14 +911,14 @@ static int openssl_set_asym_session_parameters(
asym_session->xfrm_type = RTE_CRYPTO_ASYM_XFORM_RSA;
break;
err_rsa:
BN_free(n);
BN_free(e);
BN_free(d);
BN_free(p);
BN_free(q);
BN_free(dmp1);
BN_free(dmq1);
BN_free(iqmp);
BN_clear_free(n);
BN_clear_free(e);
BN_clear_free(d);
BN_clear_free(p);
BN_clear_free(q);
BN_clear_free(dmp1);
BN_clear_free(dmq1);
BN_clear_free(iqmp);

return -1;
}
Expand Down

0 comments on commit 78807f9

Please sign in to comment.