Skip to content

Commit

Permalink
usertools: fix input handling in telemetry script
Browse files Browse the repository at this point in the history
[ upstream commit a667070 ]

This commit removes the unnecesarry ast.literal_eval() function call
from the input handling, which now relies just on raw_input() to get
its input.

Fixes: 53f293c ("usertools: replace unsafe input function")

Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
  • Loading branch information
Andrius Sirvys authored and kevintraynor committed Sep 4, 2019
1 parent 8cc0dde commit 791dcd2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions usertools/dpdk-telemetry-client.py
Expand Up @@ -76,7 +76,7 @@ def requestMetrics(self): # Requests metrics for given client

def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
print("\nPlease enter the number of times you'd like to continuously request Metrics:")
n_requests = int(ast.literal_eval(raw_input("\n:")))
n_requests = int(raw_input("\n:"))
print("\033[F") #Removes the user input from screen, cleans it up
print("\033[K")
for i in range(n_requests):
Expand All @@ -91,7 +91,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
print("[3] Unregister client")

try:
self.choice = int(ast.literal_eval(raw_input("\n:")))
self.choice = int(raw_input("\n:"))
print("\033[F") #Removes the user input for screen, cleans it up
print("\033[K")
if self.choice == 1:
Expand Down

0 comments on commit 791dcd2

Please sign in to comment.