Skip to content
Permalink
Browse files

net/ixgbe/base: fix product version check

[ upstream commit 1861e3a66ffb7fa33e7767649c7091f1900c8808 ]

The "and" condition offset == 0 && offset == NVM_INVALID_PTR
 can never be true.

Fixes: cf3af5a ("net/ixgbe/base: add functions to get version info")

Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
  • Loading branch information...
Congwen Zhang authored and kevintraynor committed Aug 8, 2019
1 parent 62aa226 commit 7f74d18bc553a4dbf5457a728cd24cb9f0a98c53
Showing with 1 addition and 1 deletion.
  1. +1 −1 drivers/net/ixgbe/base/ixgbe_common.c
@@ -5040,7 +5040,7 @@ void ixgbe_get_oem_prod_version(struct ixgbe_hw *hw,
hw->eeprom.ops.read(hw, NVM_OEM_PROD_VER_PTR, &offset);

/* Return is offset to OEM Product Version block is invalid */
if (offset == 0x0 && offset == NVM_INVALID_PTR)
if (offset == 0x0 || offset == NVM_INVALID_PTR)
return;

/* Read product version block */

0 comments on commit 7f74d18

Please sign in to comment.
You can’t perform that action at this time.