Skip to content

Commit

Permalink
build: avoid overlinking
Browse files Browse the repository at this point in the history
[ upstream commit 31b798a ]

A while ago telemetry was added in 57ae0ec and it also added as-needed
to config/meson.build. This seems no more needed these days as due to other
build changes the ordering in buildlogs is:
  [...] -lrte_telemetry [...] -Wl,--no-as-needed [...]
Which means telemetry no more benefits from --no-as-needed anyway.

Overlinking problems get triggered by the meson generated pkgconfig which
will have:
   [...] -Wl,--no-as-needed <somelibsusedbydpdk>
This will overlink <somelibs> and in addition anything that follows
as it also doesn't wrap back to --as-needed. So if a projects includes
dpdk libs + <other> it will also consider <other> with --no-as-needed.

Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759
Fixes: 57ae0ec ("build: add dependency on telemetry to apps with meson")

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Acked-by: Luca Boccassi <bluca@debian.org>
  • Loading branch information
cpaelzer authored and kevintraynor committed Dec 3, 2019
1 parent 635a8d0 commit a6a3a60
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion config/meson.build
Expand Up @@ -53,7 +53,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1)
dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8)

add_project_link_arguments('-Wl,--no-as-needed', language: 'c')
dpdk_extra_ldflags += '-Wl,--no-as-needed'

# use pthreads
add_project_link_arguments('-pthread', language: 'c')
Expand Down

0 comments on commit a6a3a60

Please sign in to comment.