Skip to content

Commit

Permalink
log: fix level picked with globbing on type register
Browse files Browse the repository at this point in the history
[ upstream commit b2a6d7e ]

When a log type is registered, the level can be picked
by matching saved options.
The check of fnmatch globbing result was reversed.

The same bug was already fixed in a similar function.
This one is acting in log type register function.

Note: this function rte_log_register_type_and_pick_level()
is not used a lot and could be merged with rte_log_register().

Fixes: 6ff0f81 ("log: fix pattern matching")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
  • Loading branch information
tmonjalo authored and kevintraynor committed May 27, 2020
1 parent 2f5fe24 commit df1c072
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/librte_eal/common/eal_common_log.c
Expand Up @@ -284,7 +284,7 @@ rte_log_register_type_and_pick_level(const char *name, uint32_t level_def)
continue;

if (opt_ll->pattern) {
if (fnmatch(opt_ll->pattern, name, 0))
if (fnmatch(opt_ll->pattern, name, 0) == 0)
level = opt_ll->level;
} else {
if (regexec(&opt_ll->re_match, name, 0, NULL, 0) == 0)
Expand Down

0 comments on commit df1c072

Please sign in to comment.