Skip to content

Commit

Permalink
usertools: fix CPU layout script to be PEP8 compliant
Browse files Browse the repository at this point in the history
[ upstream commit b0dcd61 ]

The pycodestyle tool flagged the following issues, which are now fixed.

$ pycodestyle cpu_layout.py
  cpu_layout.py:18:5: E722 do not use bare 'except'
  cpu_layout.py:62:14: E231 missing whitespace after ','

Fixes: deb87e6 ("usertools: use sysfs for CPU layout")
Fixes: c9208f1 ("usertools: fix CPU layout with python 3")

Signed-off-by: Ciara Power <ciara.power@intel.com>
  • Loading branch information
ciarapow authored and kevintraynor committed Nov 23, 2020
1 parent f4870d1 commit e60a259
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions usertools/cpu_layout.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
fd = open("{}/cpu{}/topology/core_id".format(base_path, cpu))
except IOError:
continue
except:
break
core = int(fd.read())
fd.close()
fd = open("{}/cpu{}/topology/physical_package_id".format(base_path, cpu))
Expand Down Expand Up @@ -66,7 +64,7 @@
for c in cores:
output = "Core %s" % str(c).ljust(max_core_id_len)
for s in sockets:
if (s,c) in core_map:
if (s, c) in core_map:
output += " " + str(core_map[(s, c)]).ljust(max_core_map_len)
else:
output += " " * (max_core_map_len + 1)
Expand Down

0 comments on commit e60a259

Please sign in to comment.