-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onRowSelectChange and onRowSelectAllChange not being fired #1
Comments
I didn't even realize that none of that code was being triggered. Thanks. Will be fixed in the next update today, though there are a bunch of unstable issues with the select feature in general that still need to be developed. Congrats on being this repos first issue. I'm curious to learn how dozens of people have suddenly found my (still in alpha) project in the past week. Join the discord if you are curious about the roadmap for this project as I develop it! |
all I needed to do was swap the order of the props <Checkbox
inputProps={{
'aria-label': selectAll
? localization.toggleSelectAll
: localization.toggleSelectRow,
}}
{...checkboxProps}
onChange={onSelectChange}
title={undefined}
/> |
This should now be resolved as of version 0.6.9. However, note that the |
Is this now changed to |
@domi-glyph This prop no longer exists in MRT. But the docs are very clear on how to manage the row selection state: https://www.material-react-table.com/docs/guides/row-selection#access-row-selection-state And in general, how to either manage all of the state you need (like to store in redux or whatever): https://www.material-react-table.com/docs/guides/table-state-management#manage-individual-states-as-needed |
this works, thanks! |
@KevinVandy onRowSelectionChange is not being fired for me as i am following the |
using the example at https://www.material-react-table.dev/?path=/story/features-selection-examples--on-row-select-change
Onchange events of the checkboxes are not fired:
<MaterialReactTable
columns={columns}
data={data}
enableSelection
onRowSelectChange={(event, rowState, selectedRows) => {
console.log({ event, rowState, selectedRows });
}}
/>
The text was updated successfully, but these errors were encountered: