Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullScreen breaks if isFullScreen is controlled #60

Closed
1 task done
zaverden opened this issue Sep 2, 2022 · 0 comments · Fixed by #61
Closed
1 task done

FullScreen breaks if isFullScreen is controlled #60

zaverden opened this issue Sep 2, 2022 · 0 comments · Fixed by #61

Comments

@zaverden
Copy link
Contributor

zaverden commented Sep 2, 2022

material-react-table version

1.0.0-beta.1

Describe the bug and the steps to reproduce it

if I want to control isFullScreen, MRT stops render Dialog when isFullScreen === true

  const [isFullScreen, setIsFullScreen] = useState(false);

  return (
    <MaterialReactTable
      columns={columns}
      data={data}
      onIsFullScreenChange={setIsFullScreen}
      state={{ isFullScreen }}
    />
  );

Your Minimal, Reproducible Example - Sandbox (Recommended) or code snippets

https://codesandbox.io/s/kevinvandy-material-react-table-issue-fullscreen-4yhvx2

Screenshots or Videos (Optional)

No response

Do you intend to try to help solve this bug with your own PR?

Yes, I am also opening a PR that solves the problem along side this issue

Terms

  • I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant