Fix warning in block declaration from UICountingLabel #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0mega
force-pushed
the
update-counting-label
branch
from
9d0990f
to
2ecb0a5
Compare
|
@kevinzhow Thanks for the amazing lib, can you please review and merge if looks good, happy to address any comments. |
|
Hi @kevinzhow, sorry for pinging you again but do you have an idea of when you could review this? |
ecaselles
approved these changes
Nov 16, 2017
0mega
force-pushed
the
update-counting-label
branch
from
58b174a
to
2ecb0a5
Compare
This fixes the warnings in lib's block declaration For more info dataxpress/UICountingLabel@8473972
Because it's not used
0mega
force-pushed
the
update-counting-label
branch
from
2ecb0a5
to
6bdb6bd
Compare
|
@kevinzhow All conflicts resolved and CI is green, please 👀 |
|
@kevinzhow 🙏 review this and let's 🚀 it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates UICountingLabel dependency to the latest version to remove the warning of block declaration. More info here.