Compare underlying enum types using getDisplayString
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this is correct, so I added some TODOs. This is a problem if somehow the display strings are the same, e.g. if two symbols of the same name come from different libraries. This fixes the case where an enum is nullable but has a defaultsTo value, where the default value is the non-nullable enum but the field is nullable.
|
Are you hitting this somewhere? |
|
Yeah, if you use |
|
I'm not really sure if we should just improve the warning, we could tell the user to use a non-nullable enum when they use |
|
I think that's a better idea!
…On Tue, Mar 9, 2021 at 9:49 AM John Ryan ***@***.***> wrote:
I'm not really sure if we should just improve the warning, we could tell
the user to use a non-nullable enum when they use defaultsTo
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEFCQJO4UOS7ESAJL5OUTTCZGSHANCNFSM4Y4B3GWA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is correct, so I added some TODOs. This is a problem if somehow the display strings are the same, e.g. if two symbols of the same name come from different libraries.
This fixes the case where an enum is nullable but has a defaultsTo value, where the default value is the non-nullable enum but the field is nullable.