Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published version on npm is not same as in repo #8

Open
LinusU opened this issue Oct 6, 2020 · 0 comments · May be fixed by #9
Open

Published version on npm is not same as in repo #8

LinusU opened this issue Oct 6, 2020 · 0 comments · May be fixed by #9

Comments

@LinusU
Copy link

LinusU commented Oct 6, 2020

index.js in the repository has an extra ? in the exact string interpolation, causing them to validate different things.

Published version: https://cdn.jsdelivr.net/npm/base64-regex@2.0.0/index.js
In repository: https://github.com/kevva/base64-regex/blob/0f0065cb1a1c75dc13c603c424f19103a2294782/index.js

I believe neither of the versions to be correct though, since the ? should be present in the regex for both exact and non-exact in order to match all base64 strings. Without it, it only matches 2/3 of all possible base64 strings.

@LinusU LinusU linked a pull request Oct 6, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant