Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

我想推送更新的代码,可以给我权限吗 #14

Closed
wwhyes opened this issue May 12, 2016 · 3 comments
Closed

我想推送更新的代码,可以给我权限吗 #14

wwhyes opened this issue May 12, 2016 · 3 comments

Comments

@wwhyes
Copy link
Contributor

wwhyes commented May 12, 2016

我的版本:https://github.com/wwhyes/weui-sass
1.同步weui官网demo;
2.新增首页4个图标和1个文章图片;
3.将gulp配置中的gulp-minify-css修改为gulp-clean-css;
4.新增命名空间${ns}:weui-(这部分我还没全修复,可以的话更方便项目使用);
5.修复weui_media_box中sass不支持Changing Selector Order语法;
6.修复weui_btn_title中被忽视的margin_bottom;
PS:
1.这个UI公司项目也在用,所以我也想出份力啊!
2.关于命名空间如果您同意的话,那我就大胆将所有weui_改成#{ns}了啊,栗子:weui_media_box.scss
3.还有一个问题就是那个hashchange只能翻一次页呢,所以tab那个页面就有点尴尬了

@kevyu
Copy link
Owner

kevyu commented May 12, 2016

直接提交pull request就可以了。

@wwhyes
Copy link
Contributor Author

wwhyes commented May 13, 2016

好了

@Eric-Guo
Copy link
Collaborator

看到你的PR了,感谢贡献,我暂时关掉这个issue了,后续讨论可以在#15 上进行。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants