-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot use proper REV values with vCARD 3.0 #540
Comments
@dilyanpalauzov do you have a test case for this? I tried this with both 3.0 and 4.0 and it seems to simply add it with the format advised? let x = ICAL.parse("BEGIN:VCARD\nVERSION:3.0\nEND:VCARD");
let comp = new ICAL.Component(x);
comp.addPropertyWithValue("rev", "1995-10-31T22:27:10Z");
console.log(comp.toJSON()); |
As far as I remember the problem was that it was not possible to specify, if the output shall be VCARD 3.0 or 4.0. |
Looking at https://www.rfc-editor.org/rfc/rfc2425 section 5.8.4, it looks like vcard3 "date", "time", and "date-time" values are defined as: "value types is based on a subset of the definitions in ISO 8601 standard". The examples also provide Therefore I would say YYYYMMDDTHHMMSSZ is a valid vcard3 format. Did I get that right? |
It looks like we haven't heard back on this issue, therefore we are closing this issue. If this problem persists in the latest version of ical.js, please re-open this issue. |
In VCARD 3.0 the REV property has the format:
In VCARD 4.0 the REV property has the format:
For me it seems impossible to add a property of format YYYY-MM-DDTHH:MM:SSZ to using
.addPropertyWithValue()
as the value is always converted to the YYYYMMDDTHHMMSSZ format. But I want to create VCARD 3.0.The text was updated successfully, but these errors were encountered: