Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to figure out what's up with ComputedKeyInfos.Copy() #414

Closed
akalin opened this issue May 4, 2015 · 0 comments
Closed

Need to figure out what's up with ComputedKeyInfos.Copy() #414

akalin opened this issue May 4, 2015 · 0 comments

Comments

@akalin
Copy link
Contributor

akalin commented May 4, 2015

It currently makes a shallow partial copy. The shallowness may be a bug, and the partial copy is almost certainly a bug.

Looking through the history and the surrounding code (it's used only in SigChain.LocalDelegate to make a copy of the last chain link's cki to modify), I'm guessing that it is indeed meant to be a deep copy.

The other part of this bug is figuring out the consequences of this bug and writing a regression test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants