Completely revamped flashing flow #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking the "Upload" button on the flashing card, instead of flashing right away, a dialog will pop up with some explanatory text about what will happen, and what to expect. This fixes #83. After flashing is done, we'll fall back to the keyboard selection screen, because reconnecting is not reliable yet. This should fix the white screen after flashing, and as such, this also closes #69. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
algernon
added
bug
|
Flashing is still a tad flaky, because we're closing the serial port, and opening the same one again. Ideally, if we had it open, we'd just use it. That's a separate issue, however, and one that needs deeper looking into. |
|
<3 <3 |
0957758592
referenced
this pull request
in Dygmalab/Bazecor
Nov 18, 2019
Completely revamped flashing flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking the "Upload" button on the flashing card, instead of flashing right away, a dialog will pop up with some explanatory text about what will happen, and what to expect. This fixes #83.
After flashing is done, we'll fall back to the keyboard selection screen, because reconnecting is not reliable yet. This should fix the white screen after flashing, and as such, this also closes #69.