New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro code is different from Arduino #113

Open

hoschi opened this issue Apr 23, 2022 · 1 comment

hoschi commented Apr 23, 2022 •

edited

Loading

Repo specifies
const macro_t *macroAction(uint8_t macro_id, KeyEvent &event) { here
https://github.com/keyboardio/Model01-Firmware/blob/master/Model01-Firmware.ino#L324=

Arduino sketch specifies:
const macro_t *macroAction(uint8_t macroIndex, uint8_t keyState) {

What is correct?

The text was updated successfully, but these errors were encountered:

hoschi changed the title ~~Macro code is different from docs~~ Macro code is different from Arduino

Contributor

gedankenexperimenter commented Apr 24, 2022

The version with KeyEvent is newer, and should be used unless you're compiling an old version of Kaleidoscope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment