Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Introduced a predefined mapper dialog #169

Merged
merged 6 commits into from Oct 21, 2020

Conversation

edewit
Copy link
Contributor

@edewit edewit commented Oct 13, 2020

@edewit
Copy link
Contributor Author

edewit commented Oct 13, 2020

made it a little different as I don't see how to do clickable rows in a table... I think like this it's more "in style" with patternfly

@srambach
Copy link
Contributor

I think this is meant to be a data list with selectable rows rather than a table. As it is, there's no indication that anything is clickable but the data list has that built in. https://www.patternfly.org/v4/components/data-list#selectable-rows

@ssilvert
Copy link
Contributor

ssilvert commented Oct 20, 2020

I think this is meant to be a data list with selectable rows rather than a table. As it is, there's no indication that anything is clickable but the data list has that built in. https://www.patternfly.org/v4/components/data-list#selectable-rows

Yes, that is what was intended by Kun. If you hover over the pattern link in the design you see it is datalist#selectable-rows. The link is broken but that's clearly what was intended.

The question I have about it is how do you dismiss the dialog after a row is selected. There doesn't seem to be any way to do that in the design.

@ssilvert ssilvert self-requested a review October 21, 2020 11:54
@ssilvert ssilvert merged commit a9dc031 into keycloak:master Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants