Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround for missing Content-Type: application/json #306

Closed
ueno opened this issue Jan 25, 2022 · 2 comments · Fixed by #352
Closed

Remove workaround for missing Content-Type: application/json #306

ueno opened this issue Jan 25, 2022 · 2 comments · Fixed by #352

Comments

@ueno
Copy link
Contributor

ueno commented Jan 25, 2022

Until keylime/keylime#845 the tenant and the verifier didn't set the Content-Type header properly, which required the actix handlers to manually deserialize JSON payload (for ukey and vkey). We should remove the workaround once the new python keylime has been released.
@ueno ueno added the blocked label Jan 25, 2022
@ansasaki
Copy link
Contributor

@ueno Can we remove the workaround now?

@ueno
Copy link
Contributor Author

ueno commented Mar 21, 2022

@ansasaki yeah, I think so.

@ueno ueno removed the blocked label Mar 21, 2022
@ansasaki ansasaki mentioned this issue Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

keys_handler: Remove workaround for missing JSON Content-Type ansasaki/rust-keylime
2 participants
@ueno @ansasaki