Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Landscape keyboard sized incorrectly on iPhone X #444

Closed
gabrielwong opened this issue Nov 24, 2017 · 4 comments
Closed

[iOS] Landscape keyboard sized incorrectly on iPhone X #444

gabrielwong opened this issue Nov 24, 2017 · 4 comments
Milestone

Comments

@gabrielwong
Copy link
Contributor

KeymanEngine sets the width of keyboard views to the screen width. But on iPhone X, the keyboard is not given full width in landscape.

Landscape system keyboard:
screen shot 2017-11-24 at 12 28 41 pm

Landscape in-app keyboard:
screen shot 2017-11-24 at 12 30 12 pm

Portrait system keyboard (correct but just for reference):
screen shot 2017-11-24 at 12 29 38 pm

@jahorton
Copy link
Contributor

Returning from landscape on the iPhone SE also results in display errors, leaving a gap beneath the final row of keys, much like happens with my experiments with the iPhone X simulator.

I can't help but notice that said gap when returning to portrait mode is almost exactly as tall as the in-app banner. Furthermore, the iPhoneX supports an extended display area toward the top, and the dimensions remind me of the newly unusable space we're noting within landscape...

@mcdurdin mcdurdin modified the milestones: P3S2, P3S3 May 4, 2018
@mcdurdin mcdurdin modified the milestones: P3S3, P3S4 May 18, 2018
@mcdurdin mcdurdin modified the milestones: P3S4, P3S5 Jun 4, 2018
@mcdurdin
Copy link
Member

This is potentially partially fixed with #981. Now testing.

@mcdurdin
Copy link
Member

Rotation issues resolved with #981 but sizing is still inaccurate.

@mcdurdin
Copy link
Member

Current status is that sizing is still incorrect. It is best in system keyboard portrait mode, which is probably the most common size. So may postpone this to after release?

in-app keyboard portrait:
image

in-app keyboard landscape right:
image

in-app keyboard landscape left:
image

system keyboard portrait:
image

system keyboard landscape right:
image

system keyboard landscape left:
image

@mcdurdin mcdurdin modified the milestones: P3S5, Future Jun 13, 2018
@mcdurdin mcdurdin modified the milestone: Future Jun 29, 2018
@tombogle tombogle changed the title Landscape keyboard sized incorrectly on iPhone X [iOS] Landscape keyboard sized incorrectly on iPhone X Sep 4, 2018
@jahorton jahorton added this to the 11.0 milestone Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants