You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following functions can be renamed or even removed now that legacy core has been removed. #8593
// Core was mainly as a point of difference vs the windows engine core while the feature flag was present. So could remove the core name
ReleaseKeyboardMemoryCore
ReleaseStateMemoryCore
// These functions are about saving and restoring the keyboard option list in the core. used in the case of testing a keystroke
// Due to the optimisation of just using the cached core actions in the case of the !Updateable call there is no longer a need for these 3
// functions and there test cases so can be removed as dead code.
UpdateKeyboardOptionsCore
SaveKeyboardOptionsCore
RestoreKeyboardOptionsCore
DisposeKeyboardOptionsCore
// Used for loading and saving options between the core loaded keyboard and the windows registry. Core was mainly as a point of difference vs the windows engine core while the feature flag was present.
// it does cary more meaning and suggest a name the suggest the flow of data LoadKeyboardOptionsREGtoCore. SaveKeyboardOptionCoretoReg
LoadKeyboardOptionsREGCore
SaveKeyboardOptionREGCore
// Was named when refactoring the ProcessEvent call to be better optimised around the TSF not updatable call
Process_Event_Core
// The Core was mainly as a point of difference vs the windows engine core while the feature flag was present. So could remove the core name
MapKeyboardCore
MapKeyRuleCore
The text was updated successfully, but these errors were encountered:
rc-swag
changed the title
chore(windows): Rename functions if "Core" in name is redundant
chore(windows): Rename functions if "Core" in name is redundant ⛏️
May 3, 2023
The following functions can be renamed or even removed now that legacy core has been removed. #8593
// Core was mainly as a point of difference vs the windows engine core while the feature flag was present. So could remove the core name
ReleaseKeyboardMemoryCore
ReleaseStateMemoryCore
// These functions are about saving and restoring the keyboard option list in the core. used in the case of testing a keystroke
// Due to the optimisation of just using the cached core actions in the case of the !Updateable call there is no longer a need for these 3
// functions and there test cases so can be removed as dead code.
UpdateKeyboardOptionsCore
SaveKeyboardOptionsCore
RestoreKeyboardOptionsCore
DisposeKeyboardOptionsCore
// Used for loading and saving options between the core loaded keyboard and the windows registry. Core was mainly as a point of difference vs the windows engine core while the feature flag was present.
// it does cary more meaning and suggest a name the suggest the flow of data LoadKeyboardOptionsREGtoCore. SaveKeyboardOptionCoretoReg
LoadKeyboardOptionsREGCore
SaveKeyboardOptionREGCore
// Was named when refactoring the ProcessEvent call to be better optimised around the TSF not updatable call
Process_Event_Core
// The Core was mainly as a point of difference vs the windows engine core while the feature flag was present. So could remove the core name
MapKeyboardCore
MapKeyRuleCore
The text was updated successfully, but these errors were encountered: