Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(windows): Rename functions if "Core" in name is redundant ⛏️ #8703

Closed
rc-swag opened this issue May 3, 2023 · 0 comments · Fixed by #8707
Closed

chore(windows): Rename functions if "Core" in name is redundant ⛏️ #8703

rc-swag opened this issue May 3, 2023 · 0 comments · Fixed by #8707

Comments

@rc-swag
Copy link
Contributor

rc-swag commented May 3, 2023

The following functions can be renamed or even removed now that legacy core has been removed. #8593

  • // Core was mainly as a point of difference vs the windows engine core while the feature flag was present. So could remove the core name
    ReleaseKeyboardMemoryCore
    ReleaseStateMemoryCore

  • // These functions are about saving and restoring the keyboard option list in the core. used in the case of testing a keystroke
    // Due to the optimisation of just using the cached core actions in the case of the !Updateable call there is no longer a need for these 3
    // functions and there test cases so can be removed as dead code.
    UpdateKeyboardOptionsCore
    SaveKeyboardOptionsCore
    RestoreKeyboardOptionsCore
    DisposeKeyboardOptionsCore

  • // Used for loading and saving options between the core loaded keyboard and the windows registry. Core was mainly as a point of difference vs the windows engine core while the feature flag was present.
    // it does cary more meaning and suggest a name the suggest the flow of data LoadKeyboardOptionsREGtoCore. SaveKeyboardOptionCoretoReg
    LoadKeyboardOptionsREGCore
    SaveKeyboardOptionREGCore

  • // Was named when refactoring the ProcessEvent call to be better optimised around the TSF not updatable call
    Process_Event_Core

  • // The Core was mainly as a point of difference vs the windows engine core while the feature flag was present. So could remove the core name
    MapKeyboardCore
    MapKeyRuleCore

@rc-swag rc-swag changed the title chore(windows): Rename functions if "Core" in name is redundant chore(windows): Rename functions if "Core" in name is redundant ⛏️ May 3, 2023
@mcdurdin mcdurdin added this to the A17S12 milestone May 5, 2023
@mcdurdin mcdurdin linked a pull request May 5, 2023 that will close this issue
@mcdurdin mcdurdin modified the milestones: A17S12, A17S13 May 14, 2023
@rc-swag rc-swag closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants