Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(android,ios,web): Move globe hint implementation from mobile platforms into Web #9596

Open
darcywong00 opened this issue Sep 20, 2023 · 1 comment

Comments

@darcywong00
Copy link
Contributor

          `createKeyTip` and `startLongpress` should be removed from `EmbeddedGestureConfig`.

I also think that the globe hint should be reimplemented in KeymanWeb, so we don't need any of this glue, and so it can be themed later. (This can be a separate pull)

Originally posted by @mcdurdin in #9591 (comment)

Relates to #9573

@jahorton
Copy link
Contributor

Since the description is lacking...

As far as I can tell, the globe hint still exists on both Android and iOS - this wasn't removed by #9591. It's that we wish to redo it, removing it from mobile-platform-native code and placing it entirely in Web, rather than need to maintain the specialized cross-WebView pattern longterm.

@jahorton jahorton changed the title chore(web): Reimplement globe hint change(web): Move globe hint implementation from mobile platforms into Web Sep 25, 2023
@jahorton jahorton added this to the 18.0 milestone Sep 25, 2023
@jahorton jahorton changed the title change(web): Move globe hint implementation from mobile platforms into Web change(android, ios, web): Move globe hint implementation from mobile platforms into Web Sep 25, 2023
@jahorton jahorton changed the title change(android, ios, web): Move globe hint implementation from mobile platforms into Web change(android,ios,web): Move globe hint implementation from mobile platforms into Web Sep 25, 2023
@jahorton jahorton changed the title change(android,ios,web): Move globe hint implementation from mobile platforms into Web refactor(android,ios,web): Move globe hint implementation from mobile platforms into Web Sep 25, 2023
@mcdurdin mcdurdin modified the milestones: 18.0, A18S21 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants