Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

question(developer): do we remove kmcomp.exe entirely in 17.0? 馃棞 #9158

Closed
8 tasks
Tracked by #9235
mcdurdin opened this issue Jul 4, 2023 · 2 comments 路 Fixed by #9571
Closed
8 tasks
Tracked by #9235

question(developer): do we remove kmcomp.exe entirely in 17.0? 馃棞 #9158

mcdurdin opened this issue Jul 4, 2023 · 2 comments 路 Fixed by #9571

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Jul 4, 2023

This is a discussion issue around the pros/cons of removing kmcomp.exe and kmcmpdll.dll entirely from 17.0, forcing a move to kmc throughout.

In order to do this we still need to:

  1. Complete the kmc-kmn/kmw-compiler fixes
  2. Add support for keyboard_info merge
  3. Move tike.exe integration to using kmc instead of kmcmpdll
  4. Update keyboard repository build scripts to use kmc

Pros

  • one codebase to maintain
  • one less Windows dependency
  • forces us to make sure kmc does everything in 17.0, rather than letting some edge cases drift to 18.0
  • your pros here

Cons

  • keyboard developer may encounter bug in kmc, forced to move back to KMDev 16.0 to continue work
  • your cons here

Scenarios

  • kmcomp wrapper interface for kmc? Does this make sense to write?
    • pro: pathway for existing users
    • pro: lets user do changeover on their timetable
    • con: More to maintain
    • con: delays the changeover to kmc
  • think through handling regressions, etc.
@mcdurdin mcdurdin added this to the A17S16 milestone Jul 4, 2023
@mcdurdin
Copy link
Member Author

mcdurdin commented Jul 4, 2023

@LornaSIL notes that kmdecomp is still needed. Question: do we include it as part of kmdev17 or just a legacy separate download (legacy separate download may allow us to remove a number of legacy files from the source tree, but may be worth moving those into the kmdecomp folder?)

@mcdurdin mcdurdin modified the milestones: A17S16, A17S17 Jul 10, 2023
@mcdurdin mcdurdin modified the milestones: A17S17, A17S18 Jul 24, 2023
@keymanapp-test-bot keymanapp-test-bot bot changed the title question(developer): do we remove kmcomp.exe entirely in 17.0? question(developer): do we remove kmcomp.exe entirely in 17.0? 馃棞 Jul 27, 2023
@mcdurdin
Copy link
Member Author

mcdurdin commented Aug 2, 2023

Suggest turning kmcomp.exe into a stub program that prints help on how to migrate to kmc, with link to full migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant