New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notice profiling activated once it is really activated #74

Closed

Unitech opened this issue May 9, 2018 · 2 comments

Assignees

Member

Unitech commented May 9, 2018 •

edited

This: https://github.com/keymetrics/pmx-2/blob/f3d1477b459a350b36c2429dd16a26ad62c89928/src/features/profiling.ts#L30

Should be just after this:

https://github.com/keymetrics/pmx-2/blob/master/src/profiling/profilingCPUFallback.ts#L23

Else the frontend will think that the profiling work but he did not installed the profiler

Same for inspector (but I guess that it is already available so just send true)

Contributor

wallet77 commented May 11, 2018

good catch I will fix that !

wallet77 self-assigned this

Contributor

wallet77 commented May 14, 2018

Done : #82

wallet77 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment