Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address passed to ks_asm() not applied to labels #43

Closed
iksteen opened this issue May 11, 2016 · 3 comments
Closed

Address passed to ks_asm() not applied to labels #43

iksteen opened this issue May 11, 2016 · 3 comments

Comments

@iksteen
Copy link
Contributor

iksteen commented May 11, 2016

When you pass an address to ks_asm() and reference a label the address is not added to the encoded address (at least on x86).
@iksteen iksteen mentioned this issue May 11, 2016
Merged
@iksteen
Copy link
Contributor Author

iksteen commented May 12, 2016

Not sure yet if this is the right way to go, but currently experimenting with passing Address through the various Finish functions to adjust the symbol fixups. Relatively crude but seems to do the trick.

@aquynh
Copy link
Member

aquynh commented May 12, 2016

yes i had to do similar thing for ARM before. please send a PR for reviewing, thanks.

@iksteen
Copy link
Contributor Author

iksteen commented May 13, 2016

This was fixed in PR #45.

@iksteen iksteen closed this as completed May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iksteen @aquynh