Feat: Removed sql-ts #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queries are built manually by the keyv-sql package instead of depending on external packages Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
|
@Jytesh do you think makes sense to target LTS (Node14) and current (Node15) on GitHub Action tests? Just to be sure the change works for both |
|
I was thinking we can add all even versions from 10 - 15 ( including 15 ) |
|
Since we shouldn't drop support for 10 just yet |
|
if the idea is going to ship this as a major version, then it's a good opportunity to drop old node versions 🙂 I think node 12 could be the oldest version supported. Check this for adding the matrix version of Node.js for testing: https://docs.github.com/en/actions/guides/building-and-testing-nodejs |
|
Aight 12 sounds good. |
|
12, 14 and 15 to be tested then? |
Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
|
yes! |
Kikobeats
approved these changes
Apr 20, 2021
|
awesome 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queries are built manually by the keyv-sql package instead of depending on external packages
Signed-off-by: Jytesh 44925963+Jytesh@users.noreply.github.com
Fixes #2, Fixes https://github.com/lukechilds/keyv-sql/issues/26
sql-ts is not compatible with node v10.