Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat. add has method #7

Merged
merged 6 commits into from Jun 19, 2021
Merged

feat. add has method #7

merged 6 commits into from Jun 19, 2021

Conversation

Jytesh
Copy link
Collaborator

@Jytesh Jytesh commented May 20, 2021

closes #6

Signed-off-by: Jytesh 44925963+Jytesh@users.noreply.github.com

Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
@Jytesh Jytesh requested a review from Kikobeats May 21, 2021 13:25
@Jytesh
Copy link
Collaborator Author

Jytesh commented May 24, 2021

@Kikobeats so this optionally checks for has and falls back to get

@Kikobeats
Copy link
Member

oh, that's smart, I like it.

Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
@Jytesh
Copy link
Collaborator Author

Jytesh commented May 25, 2021

Should this be merged or should I had has() functions for all official adaptors

@Kikobeats
Copy link
Member

can you check the conflict?

Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
@Jytesh
Copy link
Collaborator Author

Jytesh commented May 26, 2021

Only after redis namespace is fixed tests will pass

@Kikobeats Kikobeats changed the title Feat: has feat. add has method Jun 19, 2021
@Kikobeats Kikobeats marked this pull request as ready for review June 19, 2021 14:22
Kikobeats and others added 3 commits June 19, 2021 16:35
Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
@Kikobeats Kikobeats merged commit d887e36 into master Jun 19, 2021
@Kikobeats Kikobeats deleted the feature-has branch June 19, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add .has method
2 participants