Refactor: Removed official adapters, added iterators #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed keyv.options.store to keyv.store,\nkeyv.iterator() yields an asyncIterator with all entries\nAdded tests for iterators\nRemoved official tests Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
Signed-off-by: Jytesh <44925963+Jytesh@users.noreply.github.com>
|
@Kikobeats Tests pass now, would be wonderful if you could review and let me know about the iterator and adaptor loading |
|
I might wanna merge all this commits into one |
|
that's great 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed keyv.options.store to keyv.store,
<Keyv>.iterator()yields an asyncIterator with all entriesAdded tests for iterators
Removed official tests
Signed-off-by: Jytesh 44925963+Jytesh@users.noreply.github.com