Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release latest changes to Maven Central #348

Closed
GabrielBottari opened this issue Oct 14, 2021 · 12 comments
Closed

Release latest changes to Maven Central #348

GabrielBottari opened this issue Oct 14, 2021 · 12 comments

Comments

@GabrielBottari
Copy link

New changes we're recently made to support the library with Gradle version 7.0.2+. It is currently not available on the latest release, as it dates back a few months. Can we have a new version released on Maven Central? @kezong

Thank you!

@Judas
Copy link
Contributor

Judas commented Oct 15, 2021

I'd be glad to get an ETA on this too.

@kezong
Copy link
Owner

kezong commented Oct 18, 2021

Have you solved the problems you encountered by updating the latest plugin source locally?
I hope you can help check it.

@DDeg
Copy link

DDeg commented Oct 19, 2021

I use plugin built from PR#341 on pretty large project. Works fine on AGP 7.0.3 + Gradle 7.2 for a while now, aar and jar includes correctly.

@Judas
Copy link
Contributor

Judas commented Oct 22, 2021

After testing with the latest version on master branch it seems there is still an issue. External dependencies are embedded correctly, but the ones from submodules projects using embed(project(":submodule")) are not embedded in the final aar.

Tested with AGP 7.0.3 and Gradle 7.2

@GabrielBottari
Copy link
Author

After testing with the latest version on master branch it seems there is still an issue. External dependencies are embedded correctly, but the ones from submodules projects using embed(project(":submodule")) are not embedded in the final aar.

Tested with AGP 7.0.3 and Gradle 7.2

That is indeed the issue I was facing.. Submodules aren't being embedded properly

@DDeg
Copy link

DDeg commented Oct 22, 2021

@Judas @GabrielBottari can you share test project configuration where issue is reproducible?
It works just fine on my project with many submodules included as embed dependencies.

@Judas
Copy link
Contributor

Judas commented Oct 23, 2021

Here is a simple project to reproduce. It's a library project embedding a sublibrary module. The library project has dev & prod flavors. If you run the ./gradlew clean assembleDevDebug you'll see that the sublibrary classes are not embedded in the library generated aar (using latest master plugin).

I'm still debugging with my local plugin, for now I am trying to find why FlavorArtifact.getBundleTask returns a null TaskProvider
EmbedTest.zip

@Judas
Copy link
Contributor

Judas commented Nov 3, 2021

@DDeg Have you been able to test/reproduce the issue ?
@kezong would you have some time to review the PR to check if the proposed workaround is relevant ?

@GabrielBottari
Copy link
Author

For some reason, it seems to work for me right now for gradle 7.0.2 for the latest release 1.3.6. I'll keep testing and let you guys know if it breaks again.

@Judas
Copy link
Contributor

Judas commented Dec 2, 2021

@kezong with the PR about this issue now being merged, is there any release incoming?
Or are there other Gradle 7 issues pending?

@FDuhen
Copy link

FDuhen commented Feb 8, 2022

Bump, having the issue described here with Gradle 7.2 and AGP 7.1.0, a release would be appreciated

@kezong
Copy link
Owner

kezong commented Feb 17, 2022

Released in version 1.3.7

@kezong kezong closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants