New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxNumSubviews == -1 #17
Comments
Yeah, I think it's fork specific, as in the definition Int(floor(stackView.frame.size.width / (stackView.frame.size.height + stackView.spacing))) - 1 the ratio is evaluated to 0, which is then turned to -1. Thoughts on submitting a fix? |
@peterkos thank your for reporting this issue. It should be checked whether maxNumSubviews and divisor are valid or not. I will try to fix it when I am available. BTW, I would appreciate it if you can help fix it or provide reproduce test cases. |
I'm busy through the weekend, so I wont' be able to investigate further until then. But here's my temporary fix: + var views = viewsInStackView
+ // Overwrite if too many views
+ if (viewsInStackView.count > maxNumSubviews && maxNumSubviews >= 0) {
+ views = Array(viewsInStackView[0..<maxNumSubviews])
+ } |
Same here |
Not sure how to reproduce this, but for some reason
maxNumSubviews
ends up being -1, which causes a crash inTimelineTableViewCell
on this line:Just curious if anyone else has had this problem?
I'm working on a fork on my end, so it may be caused by that. However refactoring this line to be a bit cleaner couldn't hurt
The text was updated successfully, but these errors were encountered: