Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped working in newest Slack version #27

Open
karlwilbur opened this issue Dec 18, 2019 · 5 comments
Open

Stopped working in newest Slack version #27

karlwilbur opened this issue Dec 18, 2019 · 5 comments

Comments

@karlwilbur
Copy link
Contributor

This seems to have stopped working in the newest version of Slack. I am running the Slack Desktop app on Ubuntu 18.04.

This was working for me previously. I am constantly running Slack in "developer mode" and after each restart I have to copy-paste the content of index.js from slack-disable-wysiwyg-bookmarklet into the console in Slack. This was working as expected until very recently. I am noticing today that is no longer works to disable the WYSIWYG editor. I still have format-as-you-type functionality enabled in Slack. Additionally, I have discovered a new "feature" that is when I paste content with markdown in it:

`bar` should not be formatted until I submit

...I am seeing a little popup message that says "Apply Formatting?". If I do not apply formatting, this message doesn't get formatted at all. I was able to submit a message with Markdown and have it work as expected (that is display as formatted text in the chat history). This seems to have changed within the last few days.

> slackDebug.versionInfo
{
  versionHash: "0756f06a6f0457de4e355149a4321a9abb8befa5", 
  versionTs: "1576605650", 
  minVersionDataTs: 1573504200
}
@pocc
Copy link
Contributor

pocc commented Dec 20, 2019

@kfahy Is this a problem with how redux dispatches?

@kfahy
Copy link
Owner

kfahy commented Dec 20, 2019

Ahh yeah, good find. My guess is that Slack decoupled the feature from the "wysiwyg" AB tests. The script had worked by deleting some AB tests from the client, which effectively disabled them. In the latest version of the client, even if I try to delete all the AB tests in this manner, the new editor is still enabled.

@evandrix
Copy link

bump

@aasdkl
Copy link

aasdkl commented Jan 13, 2020

We can disable this feature in preferences now! 🎉
https://github.com/kfahy/slack-disable-wysiwyg-bookmarklet#update

@NiklasBr
Copy link

@aasdkl yes, but no.

It is still a significant degradation. For example, if you "disable" you cannot write lists like this:

 * One line
   - Indented
 * Second line

It will not be parsed as markdown to create a list like it used to (prior to this awful WYSIWYG)

  • One line
    • Indented
  • Second line

The output will instead look something like this:

* One line
- Indented
* Second line

It is bad and Slack should feel bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants