Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improvements #7

Closed
kffl opened this issue Jul 19, 2022 · 0 comments · Fixed by #10
Closed

Logging improvements #7

kffl opened this issue Jul 19, 2022 · 0 comments · Fixed by #10
Assignees
@kffl
Labels
enhancement New feature or request

Comments

@kffl
Copy link
Owner

kffl commented Jul 19, 2022

As of now, logging is done via fmt.Printf and fmt.Println, which doens't scale well. A logging library could be used instead that would support:

  • different log levels (specified via a CLI flag)
  • key/value pairs added to log entries (i.e. connection ID, error)
  • child loggers with fixed k/v pairs (i.e. connection-scoped ones that would include the connection ID)
@kffl kffl self-assigned this Jul 19, 2022
@kffl kffl added the enhancement New feature or request label Jul 19, 2022
@kffl kffl mentioned this issue Jul 19, 2022
Merged
@kffl kffl closed this as completed in #10 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kffl kffl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: logging improvements (log levels, go-hclog) kffl/speedbump
1 participant
@kffl