Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G729 Codec #8

Closed
GoogleCodeExporter opened this issue Apr 16, 2015 · 80 comments
Closed

G729 Codec #8

GoogleCodeExporter opened this issue Apr 16, 2015 · 80 comments

Comments

@GoogleCodeExporter
Copy link

Implement the G729 Codec

Original issue reported on code.google.com by r3gis...@gmail.com on 20 Mar 2010 at 8:39

@GoogleCodeExporter
Copy link
Author

Original comment by r3gis...@gmail.com on 20 Mar 2010 at 8:42

  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

pentor88@gmail.com

Original comment by pento...@gmail.com on 11 Apr 2010 at 3:15

@GoogleCodeExporter
Copy link
Author

+1, I would love to have G729 Codec support

Original comment by anishna...@gmail.com on 20 May 2010 at 1:29

@GoogleCodeExporter
Copy link
Author

+1, with low umts band G729 is essential.

Original comment by markmar1...@gmail.com on 7 Jun 2010 at 10:25

@GoogleCodeExporter
Copy link
Author

I Agree, really need G729

Original comment by niitserv...@gmail.com on 21 Jun 2010 at 5:14

@GoogleCodeExporter
Copy link
Author

really want g729. that would be awesome

Original comment by xavierdy...@gmail.com on 9 Jul 2010 at 10:48

@GoogleCodeExporter
Copy link
Author

g729, thank you so much!

Original comment by mgshu...@gmail.com on 21 Jul 2010 at 1:41

@GoogleCodeExporter
Copy link
Author

Think someone mentioned it somewhere here before, but sipphon which is also 
based on pjsip has some G729 code which I assume could be ported. However the 
patent issue might be a cause for concern in this case.

The way around it is to either rely on a disclaimer telling the user its up to 
him or her and then hope no lawyer comes calling... the other way would be to 
have a market version with a pricetag covering the patent fee. This might not 
actually be such a bad idea but it would require a license deal from someplace 
other the sipro since they charge some ridiculous initial amount just to sign 
up. Maybe something like http://www.synapseglobal.com/g729_codec_license.html
But I guess that begs the question if anyone would actually pay 10-15 bucks to 
get a version containing G729...

Original comment by michael....@gmail.com on 21 Jul 2010 at 11:49

@GoogleCodeExporter
Copy link
Author

please note, you should purchase license only if you transcode something with 
g729. nypassing g729 is absolutely free

Original comment by zdevel on 22 Jul 2010 at 6:26

@GoogleCodeExporter
Copy link
Author

Softphones require licenses at least according to sipro if I remember 
correctly. The bypassing case would apply if I had an asterisk server just 
passing the stream along but the softphone would still require a patent license.

Original comment by michael....@gmail.com on 22 Jul 2010 at 6:49

@GoogleCodeExporter
Copy link
Author

For the technical part, I'm in contact with Samuel who write siphon and its 
g729 implementation for arm. 
He (and I) think that just including his code will be enough to support g729. 
I'll probably try it today :)

For the license part.... it's more complicated.  
I agree with micheal's comment and that's also what Samuel explained to me. 
Thanks a lot micheal for the SynapseGlobal link. I didn't know that there where 
retailers that allow a per license purchase. Really interesting !! It could be 
easier to manage than the sipro solution that afraid me a lot !!!

In the case I get a solution to manage the license, the best solution is to 
provide a plugin app on the market that provide an updated version of the 
dynamic library. Some changes has to be done in the update process but that was 
already planned.

This method will sip providers to provide their own application that relies on 
CSipSimple and include a g729 library if they already pay fees for their users.



Original comment by r3gis...@gmail.com on 22 Jul 2010 at 7:30

@GoogleCodeExporter
Copy link
Author

Just out of curiosity did you try to get this working yet?

Original comment by michael....@gmail.com on 25 Jul 2010 at 1:36

@GoogleCodeExporter
Copy link
Author

Yes, 

Thanks to the very great support from Samuel (author of Siphon), I get 
something that build.

There is one thing I miss to be able to test... Allow local accounts (because 
all my registrar rewrite invite offers and doesn't allow g729 :D ).
I'm pretty confident in the fact that it will work, but I don't know what will 
be the performances.
In fact, for the Iphone version, it was possible to use assembler code, but for 
android, since we commonly use a aebi assembler, instructions are not the same, 
so I fall back to generic code. Less efficient but that build within the NDK.

For now, my priority is to implement filters and rewriting rules for native 
dialer intergration. But I continue this task in background.

Original comment by r3gis...@gmail.com on 25 Jul 2010 at 2:14

@GoogleCodeExporter
Copy link
Author

If you don't have a place to test g729, you can get in touch (egcrosser at 
gmail) and I'll set up an account for you on my system.

Original comment by egcros...@gmail.com on 26 Jul 2010 at 5:12

@GoogleCodeExporter
Copy link
Author

Performance might still be ok using the latest android devices which have 
pretty descent hardware. Will be interesting to see the results of the tests.

Original comment by michael....@gmail.com on 26 Jul 2010 at 9:45

  • Added labels: OpSys-All

@GoogleCodeExporter
Copy link
Author

Well, thanks for your nice proposition egcrosser but I've just succeeded using 
one of my sip server without SBC.

So after many tests (there is still bugs with the codec priority management), 
my calls between a HTC Sapphire (Magic / G2) and Nexus One using G729. (Both 
handset use wifi)

Result is pretty good. Latency is really low. Sometimes (probably due to VAD) I 
get some choppy sound on the G2 but sound is clear on Nexus One.

So it's worth to be continued. For now what I did is just unreleasable : I made 
code to allow compilation at midnight... But I'll try to do something more 
clean, and contribute it back to Samuel's Siphon project once it will be enough 
clean. And of course it will be available on my repo.

Meanwhile, I'll get more information about how to solve this licensing issue. 
SynapseGlobal sounds a good solution, but give license for special 
implementation (such as Asterisk's one). And there is maybe a little trick with 
the fact that a exception to GPL has to be added in code license to allow the 
*distribution* with the G729 license.

Original comment by r3gis...@gmail.com on 26 Jul 2010 at 12:31

@GoogleCodeExporter
Copy link
Author

I also agree that g729 would improve voice quality! What is the situation now 
with project?

Original comment by jar...@gmail.com on 16 Aug 2010 at 9:22

@GoogleCodeExporter
Copy link
Author

[deleted comment]

1 similar comment
@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

Hi r3gis.3R , 

   When i build project (include g729 ) with ndk i recived "Error: selected processor does not support `smulbb" so i don't know how to Solved it  , so please send me your g729 source code project , my mail is bravechou2009@gmail.com thanks in advance!!!!!!!!!!!!!!!!!!!!!!!!!

Original comment by bravecho...@gmail.com on 24 Aug 2010 at 6:20

@GoogleCodeExporter
Copy link
Author

Hi r3gis.3R ,

Would you please send me your g729 source code project too? My mail is 
mgshuter@gmail.com   

Thank you so much!!

Best Regards,
Arthur Chiang

Original comment by mgshu...@gmail.com on 25 Aug 2010 at 6:08

@GoogleCodeExporter
Copy link
Author

I support work on adding g729 to CSIPSIMPLE.  This would put it far ahead of 
other open source SIP apps for Android.  My VOIP provider only seems to support 
the g729 codec, so it is somewhat of a key feature for me.

I don't know the first thing about compiling, but I can offer to test builds on 
my HTC Hero running VillainRom 10.3.2 (Android OS 2.1)

Original comment by ben...@gmail.com on 26 Aug 2010 at 8:24

@GoogleCodeExporter
Copy link
Author

I think it's ok to include g729 codec without additional fee as all SIP 
providers already paid license fees. Mine (sipnet.ru) already gives windows 
softphone with g729 codec for free. 

Original comment by xnov...@gmail.com on 4 Sep 2010 at 9:00

@GoogleCodeExporter
Copy link
Author

G729 codec is essential in Voip. I propose to make it a paid add on like the 
bria softphone in the apple store.

Original comment by dcitele...@gmail.com on 9 Sep 2010 at 9:57

@GoogleCodeExporter
Copy link
Author

IMHO you should include it disabled by default for those who already have a 
G729 license making this clear on the about menu, that is if they don't require 
any GPL exception.

Original comment by marcu...@gmail.com on 18 Sep 2010 at 1:25

@GoogleCodeExporter
Copy link
Author

ok, that is great. My sip provider has already paid the license so it is good 
that we don't have to paid it twice.

Do you have any plans when 0.00-16 could be in market?

Original comment by jar...@gmail.com on 25 Nov 2010 at 12:20

@GoogleCodeExporter
Copy link
Author

Sip provider must have pay *for you*. 
Cause they can have paid just for their channels in SIP trunks.

The best is to ask them directly if they monitor their number of users and 
reverse the little fee for each of their users (for a sip provider it cost 
really less than for users to buy the g729 codec cause they buy the entry cost 
which is expansive but once paid, each channel cost is ridiculous (less than 1$ 
I think) ).


Original comment by r3gis...@gmail.com on 25 Nov 2010 at 12:25

@GoogleCodeExporter
Copy link
Author

so any ETA on the 0.00-16 version?= r3gis.3r?

Original comment by xavierdy...@gmail.com on 30 Nov 2010 at 11:45

@GoogleCodeExporter
Copy link
Author

Please try to get the g729 codec in!  Would be nice to see if it makes a 
difference, the GSM is breaking up on 3g

Original comment by BrianPYe...@gmail.com on 2 Dec 2010 at 6:55

@GoogleCodeExporter
Copy link
Author

that's good news since bria for Android includes the G729 codec and if you 
don't move fast you will lose your startup advantage. Csipsimple is a great 
product and more mature than Bria (for now) but ultimately VoIP is about voice 
quality and if you don't match their codec you lose.

Original comment by dcitele...@gmail.com on 5 Dec 2010 at 5:06

@GoogleCodeExporter
Copy link
Author

Can't wait for release with g 729!!!  :-) 

Original comment by xnov...@gmail.com on 5 Dec 2010 at 9:06

@GoogleCodeExporter
Copy link
Author

The more feedback I'll have on current builds (see download section) the more 
quickest will be the release of the next stable version on the market ;).
All the more so as it's good feedback (cause I'm not always sure that my 
improvements doesn't introduce regressions). If a majority say me : "ok latest 
build is enough stable for me", I'll release ;).


@dcitelecom : there is no war between sip softphone ;) . My goal is not to have 
a market lead or something like that. It's just an opensource app I develop for 
my pleasure ;). If some enterprise want to promote it and help the development 
by contributing source code it will be welcomed. 
I think that finally true Opensourceness of any software project will at the 
bottom line lead to a better user experience (cause GPL make users the center 
of the software - made by users for users).


Original comment by r3gis...@gmail.com on 5 Dec 2010 at 10:25

@GoogleCodeExporter
Copy link
Author

ok latest build is enough stable for me

Original comment by huan...@gmail.com on 5 Dec 2010 at 10:38

@GoogleCodeExporter
Copy link
Author

Hi there,
Just downloaded the latest version, 018 and I don't see g729 there.
Do I need to do something in addition to get that codec?
Nexus one with cm 6.1 rc 2

Thanks a lot for all the effort :-)

If you need someone somewhat technical to do additional testing or stuff like 
that, I will be glad to help.


Original comment by makal...@gmail.com on 7 Dec 2010 at 9:38

@GoogleCodeExporter
Copy link
Author

Currently building the lib for releasing on the market 0.00-16 ...

Will you be able to wait for about 1 hour ? ;) ...

Original comment by r3gis...@gmail.com on 7 Dec 2010 at 9:45

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

:)
My wife staring at me suspiciously,
as to why I look at bug tracking screen and smiling like a 10 year old that got 
free candy.

Original comment by makal...@gmail.com on 7 Dec 2010 at 9:49

@GoogleCodeExporter
Copy link
Author

http://code.google.com/p/csipsimple/downloads/detail?name=CSipSimple_0.00-16-00.
apk 

Original comment by r3gis...@gmail.com on 7 Dec 2010 at 10:36

@GoogleCodeExporter
Copy link
Author

Just did the update.
Working perfectly, so far.
Finally I can receive calls through my preferred sip provider.

Thanks.

Original comment by makal...@gmail.com on 7 Dec 2010 at 10:44

@GoogleCodeExporter
Copy link
Author

How do I know if I am using the G729 codec?

I installed the website and market version of the "16 apk" program and don't 
see the G729 listed under the available codecs.

Original comment by rautiala...@gmail.com on 8 Dec 2010 at 5:10

@GoogleCodeExporter
Copy link
Author

Mmmm, G729 should be listed in codec (makalsky could you confirm? - I've 
installed on an other phone and it work). 
Btw, you can force the installation of a bundled apk using 0.00-16-00 
(different from 0.00-16 and market version that get back the native part of the 
application on the web). 
g729 should appear in Settings > media > Codecs (it's the last entry). Long 
press on the codec, choose activate, read the disclamer, press OK.
You can drag and drop it on the top of the list to announce that's your 
preferred codec.

While on communication press the (i) button to see which codec is in use. 
(You'll see a lot of info and the codec on the second or third line).


Original comment by r3gis...@gmail.com on 8 Dec 2010 at 9:03

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Here G729 codec is in list. 

Original comment by jar...@gmail.com on 8 Dec 2010 at 9:18

@GoogleCodeExporter
Copy link
Author

The codec is there, but you have to scroll down to see it on some screens.
And its greyed out of course, so not that visible.

Original comment by makal...@gmail.com on 8 Dec 2010 at 9:19

@GoogleCodeExporter
Copy link
Author

The last codec I see on my phone is G.722. I can't scroll down anymore. 
Attached are a few screenshots. Let me know if you want me to capture some more 
screenshots which might prove useful.

Thanks for the support.
-Rodney

Original comment by rautiala...@gmail.com on 8 Dec 2010 at 9:29

Attachments:

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

G729 is working without problems for BudgetPhone.nl, thanks!
I wanted to contribute something, so I did some Dutch translation.
To be continued ...

Original comment by bokhorstm on 8 Dec 2010 at 9:33

@GoogleCodeExporter
Copy link
Author

I resolved my issue. Looks like I had imported data from a previous version of 
csipsimple which caused the codec not to carry over to the new version. So now, 
I see the G729 8Khz. Great forum and program!

Original comment by rautiala...@gmail.com on 8 Dec 2010 at 9:42

@GoogleCodeExporter
Copy link
Author

@rautialarodneyb : Ok, indeed make sense data imported from an older version 
contains the native library which is the core of the SIP stack and contains 
codecs. 
To workaround this kind of problem I have to fix issue 179 :) (allow save and 
restore settings)

@bokhorstm : thx for translations :).


Original comment by r3gis...@gmail.com on 8 Dec 2010 at 9:57

@GoogleCodeExporter
Copy link
Author

I can also report that G729 with Poivy (a Betamax clone) works perfectly.

Original comment by bokhorstm on 8 Dec 2010 at 12:46

@GoogleCodeExporter
Copy link
Author

Can I use G729 with csipsimple if I bought it through Bria?

Original comment by fatrodmc...@gmail.com on 9 Dec 2010 at 5:03

@GoogleCodeExporter
Copy link
Author

@fatrodmcdjs : ask that to Bria. It depends on the license they retails to you. 
If it's a g729 license directly yes you can (I mean if they retail to you the 
right to establish a g729 channel). 
If it's a license that allow you to use g729 *only* using their application, no 
you are not allowed.

Ask them :) - and if valid you can report it here, I think that it could be 
interesting for other users.

Original comment by r3gis...@gmail.com on 9 Dec 2010 at 9:46

@GoogleCodeExporter
Copy link
Author

Thanks r3gis.3R!  All working perfectly now - HTC Desire, Android 2.1, South 
Africa

Original comment by willieme...@gmail.com on 13 Dec 2010 at 9:19

@GoogleCodeExporter
Copy link
Author

Hi,

I need some indications regarding the use of G729 codec on sipsimple.

I configured csipsimple to use my sipsorcery account and I would activate G729 
codec support but I don't know if all sip providers configured on my sipsorcery 
account already pay licenses fees for that codec.

If I want to buy one license to use it with csipsimple as stated above is the 
following link right to buy a proper type of license? (or is it only for 
Asterisk?)
http://store.digium.com/productview.php?product_code=G729CODEC

If it's right is required any further action to properly register the license 
bought with my csipsimple after the purchase or I'm just finished after 
activating it in the codec menu?

Thank you very much for your support

gabriele

Original comment by lele...@gmail.com on 3 Feb 2011 at 12:44

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

lele... Man, what are you talking about!!! Digium Module are for Asterisk 
servers, not for Clients, you're mistaking, that module is for servers, not for 
client applications...

But the same which i said previously, in other thread. First it doesn't make 
sense to purchase, neither activate you codec if your service provider don't 
have that codec in service. So first contact your provider to verify if they 
have it, and if there license cover multichannel, if yes, it's enough that you 
just activate it in your client, the server license are available to cover your 
client.

Original comment by samer%al...@gtempaccount.com on 31 Mar 2011 at 5:49

@GoogleCodeExporter
Copy link
Author

Hi everybody,
I'd like to understand if using G.729 on CSIPSimple for private use I have to 
buy a license, and, second, if I configure the G.729 on CSIPSimple the calls 
work without the license? 

Original comment by Tiziano....@gmail.com on 23 Apr 2012 at 11:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant