overwrite CupertinoPicker's default selection overlay #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopasz
force-pushed
the
remove-selection-overlay
branch
from
81f7cec
to
c94b300
Compare
|
@kfiross can you please merge it? |
|
@sky1095 yep, thanks for the PR! |
|
Hi @kfiross, even after the merge we can still see the grey background. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed default CupertinoPicker selection overlay introduced in Flutter 2 to adhere to the original design of holo date picker. Fixes #32.
Note: the
selectionOverlayproperty docs say to remove it one can set it tonull, but there seems to be a bug in the Flutter framework itself that doesn't allow it when using null safety, so until a fix is rolled out for that issue, we're just going to have to settle for overwriting that property with an emptyContainer().Before:
After:
