Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dividerHeight and dividerThickness #52

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement dividerHeight and dividerThickness #52

wants to merge 3 commits into from

Conversation

jenow
Copy link

@jenow jenow commented Aug 10, 2022

What does this PR do?

Implement dividerHeight and dividerThickness to change the size of dividers.

Usage

DatePicker.showSimpleDatePicker(
  context,
  initialDate: DateTime(1994),
  firstDate: DateTime(1960),
  dateFormat: "dd-MMMM-yyyy",
  dividerHeight: 1.0,
  dividerThickness: 1.0,
);

Hyla96
Hyla96 suggested changes Feb 16, 2023
View reviewed changes
lib/date_picker.dart
@@ -189,6 +191,8 @@ class DatePicker {
_selectedDate = date;
}),
looping: looping,
dividerHeight: dividerHeight,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to move this to the theme instead, (Since the dividerColor is passed there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyla96 Hyla96 Hyla96 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jenow @Hyla96