New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reused bit in common flags bit set #7

Closed

migueloller opened this issue May 2, 2020 · 1 comment

migueloller commented May 2, 2020

I was browsing the source code and stumbled across a bit set that had a duplicate bit set ("set" being the verb here). Is this intentional?

seafox/src/parser/common.ts

Lines 58 to 59 in d5242d0

    
           CommentStart = 1 << 12, 
        
           DisallowCall = 1 << 12

migueloller changed the title ~~Reused bit in common flags~~ Reused bit in common flags bit set

KFlash closed this as completed in

8dae6ed

Owner

KFlash commented May 2, 2020

This wasn't intentional, and just a stupid slip-up! Thanks for noticing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment