Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not include H,T, and R in ciphertext #19

Open
aaannndddyyy opened this issue Nov 10, 2016 · 3 comments
Open

do not include H,T, and R in ciphertext #19

aaannndddyyy opened this issue Nov 10, 2016 · 3 comments

Comments

@aaannndddyyy
Copy link

aaannndddyyy commented Nov 10, 2016

Reading through the code comments, it looks like you are including some information in the cipher text, which IMHO should not be there.
c.f. " FFHHTTRRRR******-------------------------------------DDDD******* "

I think it should rather be like this:
FF******-------------------------------------DDDD*******

Both, sender and receiver, are in possession of the pad. Determining the length of fuzz from pad data is easily possible for both parties without the need of transmitting that info, unless you don't want random fuzz lengths

@aaannndddyyy
Copy link
Author

And do you consider F to be sensitive information that needs to be encrypted?

@kfogel
Copy link
Owner

kfogel commented Nov 17, 2016

Thanks! I think you're right -- I was careless in writing that comment. The information is not actually included in the ciphertext; it's just read from the pad at encryption and decryption time. I will update the comment to be clearer on the difference between what gets used versus what gets included in the ciphertext.

Thank you for noticing this.

Yes, I do consider F to be sensitive information. If you know F, then you know the version of OneTime that was used to encrypt the file, which means you have a lower bound -- and a probable upper bound -- on the date that the message was encrypted. This would be an unacceptable information leak about the sender's relationship to the plaintext.

@aaannndddyyy
Copy link
Author

Ok, I see your point re F. It's not an issue for me, but I understand it is for some.
Thanks for updating the comments to reflect that H,R,T are not included in the message.
If they were, they'd needlessly increase message size and disclose raw pad data.

This issue can then be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants