Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: Update Delayed Cancelis not working #75

Closed
EdLichtman opened this issue Mar 21, 2019 · 3 comments
Closed

BUG FIX: Update Delayed Cancelis not working #75

EdLichtman opened this issue Mar 21, 2019 · 3 comments

Comments

@EdLichtman
Copy link
Contributor

EdLichtman commented Mar 21, 2019

Hey Kori,

Not sure sure if the documentation has changed, but Update Delayed Cancel is not working -- there seems to be two endpoints, CancelDelayedCancel and UndoCancellation.

I'm working on a bug fix and hope this will be merged in and added soon -- I'll post as soon as pull request is up.

@EdLichtman EdLichtman changed the title BUG FIX: Update Delayed Billing is not working BUG FIX: Update Delayed Cancelis not working Mar 21, 2019
@EdLichtman
Copy link
Contributor Author

#76

@kfrancis I did this from my Windows this time but I don't have the tests pass -- awaiting discussion over gitter to figure out how to start testing. Please let me know if tests pass

@EdLichtman
Copy link
Contributor Author

Also @kfrancis I introduced some functional methods for code cleanup. I'm really excited to be using them if you like them, but I also don't want to introduce complexity for others trying to join the project. Please let me know if you would like me to rewrite them before pulling in the branch, and also please let me know if you would like me to start rewriting other methods to use these Functions

Cheers,
Eddie

@kfrancis
Copy link
Owner

kfrancis commented Apr 1, 2019

@kfrancis kfrancis closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants