Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual overview of connections FNML #13

Closed
samiscoding opened this issue Jan 24, 2023 · 9 comments
Closed

Visual overview of connections FNML #13

samiscoding opened this issue Jan 24, 2023 · 9 comments
Labels
documentation Improvements or additions to documentation

Comments

@samiscoding
Copy link
Collaborator

samiscoding commented Jan 24, 2023

I think we need to generalize the Figure 1 Visual overview of connections FNML to also cover the reference to functions as subject and probably predicate, right?

@samiscoding samiscoding added the documentation Improvements or additions to documentation label Jan 24, 2023
@dachafra
Copy link
Member

dachafra commented Jan 24, 2023

This is an interesting issue also for @anaigmo

@samiscoding
Copy link
Collaborator Author

in fact, I see that the diagram in #8 in generalized so I guess we are just missing in this visualization.

@dachafra
Copy link
Member

Shall we close this issue then? @samiscoding

@samiscoding
Copy link
Collaborator Author

mermaid-diagram-2023-01-24-165924
@bjdmeest what do you think about this modification in the figure?

@bjdmeest
Copy link
Member

bjdmeest commented Jan 25, 2023

I kept capitalization in line with the (R2)RML specs, but no problem changing it. So maybe you could make the change or just add a note to remember to keep them in line with the final spec for now?

@pmaria
Copy link

pmaria commented Jan 25, 2023

@samiscoding I don't get the replacement of function-valued term map with Output Term Map, and return with output . I don't think that's in line with the current draft.

@bjdmeest
Copy link
Member

@samiscoding I don't get the replacement of function-valued term map with Output Term Map, and return with output . I don't think that's in line with the current draft.

Ah, good catch, I glossed over that! Yeah that part of the change is not in line with what was last agreed, namely to define it similar to constant-valued term map, template-valued term map, etc

@samiscoding
Copy link
Collaborator Author

my bad! uploaded an old version of the figure. This is what I pushed to the repository
mermaid-diagram-2023-01-25-155704

@bjdmeest
Copy link
Member

bjdmeest commented Feb 1, 2023

Perfect! Closing this as it's added in the spec (and Ana's diagram too :) )

@bjdmeest bjdmeest closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants