Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Tables Overhaul #14

Open
kgar opened this issue Nov 1, 2023 · 3 comments
Open

Item Tables Overhaul #14

kgar opened this issue Nov 1, 2023 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@kgar
Copy link
Owner

kgar commented Nov 1, 2023

Item tables are currently implemented with flexbox, and when the header row becomes too crowded, it becomes off-centered from its table contents. Consider this spellbook section:

image

  • Rebuild list views so that becoming off-balance is impossible.
  • Overflow should be handled in a more controlled and predictable way.
    • Current idea 💡 specifically for Spellbook:
      • Offload the primary column title (e.g., "Pact Magic 1st Level 🟠 1/1 ✏") to a standalone header row, where this content can expand out comfortably. In place of this text, the primary column should have the column title "Spell".
    • For all sheets, the "Name" column, like the item name itself, should truncate with ellipses "..." when compressed.
    • If there are too many columns and the sheet is not wide enough to accommodate them, a dedicated horizontal scrollbar should be provided for that tab (or list?)

Consider switching to CSS Grid for building these tables.
In the re-design, build with column selection possibilities in mind (#60).

@kgar kgar added bug Something isn't working enhancement New feature or request labels Nov 1, 2023
@kgar
Copy link
Owner Author

kgar commented Nov 1, 2023

Whatever the implementation, it should support #11, if already implemented.

@crash1115
Copy link

crash1115 commented Nov 20, 2023

Gonna chuck this in here as a discussion point since it's relevant to header clutter. It would be kickass if the solution implemented here were designed in such a way that it could work in an environment where item list columns are customizable.

Very recently I was talking with my group about which things they did and didn't like about how the base dnd5e sheet displays items, and it became apparent to me that folks have different preferences for what information is easily visible. For instance, I don't need to have spell school or range listed as columns on the spellbook tab, and I would disable those if I could. Allowing people this flexibility might be a cool future feature.

@kgar
Copy link
Owner Author

kgar commented Nov 21, 2023

Two complaints I've often seen in the wild:

  • Tidy has too many tabs
  • Tidy's tables are too crowded

With the way things are going, column selection is a very compelling feature add.

The way I see it, module developers will eventually be able to register columns and append content to existing columns. So, with our tables already feeling kind of crowded in their current state, providing extensibility like actor column selection will keep things sane.

And, column selection will synergize with the work currently being done on #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants