-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item Tables Overhaul #14
Comments
Whatever the implementation, it should support #11, if already implemented. |
Gonna chuck this in here as a discussion point since it's relevant to header clutter. It would be kickass if the solution implemented here were designed in such a way that it could work in an environment where item list columns are customizable. Very recently I was talking with my group about which things they did and didn't like about how the base dnd5e sheet displays items, and it became apparent to me that folks have different preferences for what information is easily visible. For instance, I don't need to have spell school or range listed as columns on the spellbook tab, and I would disable those if I could. Allowing people this flexibility might be a cool future feature. |
Two complaints I've often seen in the wild:
With the way things are going, column selection is a very compelling feature add. The way I see it, module developers will eventually be able to register columns and append content to existing columns. So, with our tables already feeling kind of crowded in their current state, providing extensibility like actor column selection will keep things sane. And, column selection will synergize with the work currently being done on #58 |
Item tables are currently implemented with flexbox, and when the header row becomes too crowded, it becomes off-centered from its table contents. Consider this spellbook section:
Consider switching to CSS Grid for building these tables.
In the re-design, build with column selection possibilities in mind (#60).
The text was updated successfully, but these errors were encountered: