Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items on Journal tab don't render #35

Closed
dstein766 opened this issue Nov 8, 2023 · 3 comments
Closed

Items on Journal tab don't render #35

dstein766 opened this issue Nov 8, 2023 · 3 comments

Comments

@dstein766
Copy link

IF the Journal tab is a core function of Tidy (I assume it is, but if being added by another module I've completely forgotten that), then tidy-kgar isn't rendering any of the data. My test PC has data in both the Journal Entries and Miscellaneous fields. Screencaps show missing Journal Entries - I didn't bother to screencap evidence of missing Miscellaneous. I assume Persons of Interest, Locations of Interest, and Quests would also render blank although I didn't test.

Tidy (original);
lQl4hL1pqq

Tidy-kgar:
pgxbcw69qC

@kgar
Copy link
Owner

kgar commented Nov 8, 2023

Are you able to set some journal text from the alpha sheet and see it render properly?

The Journal, as well as a number of other fields, are based on flags that are specific to the Tidy 5e module, or in this case, the Tidy 5e kgar module.

Fields that are based on flag data will not carry over between the sheets during alpha testing. This includes favorites, journal, the other notes fields in the Journal tab, etc.
This is to allow side-by-side testing.

When the rewrite takes over the module ID, these flag-specific settings will carry over.
For now, they are basically separate sheets, and Tidy-specific stuff like Journal will not carry over.

@dstein766
Copy link
Author

OK - makes sense. (The specific answer to your question is that, as expected based on your explanation, new text entered in tidy-kgar DOES render under tidy-kgar (but not under tidy-original) and vice versa. Closing this issue since this is not a bug.

@kgar
Copy link
Owner

kgar commented Nov 8, 2023

Good to hear, and my apologies for any confusion.

When this project moves to beta testing, I can look into using current Tidy's actual data flags to make the final transition to v1 a smooth process. Right now, the changes are bigger and more disruptive, so I hesitate to commit to that yet.

Thank you for trying it out.

@kgar kgar closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants