Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove correctInvalidMidWordBoldAndItalics() and related tests #3

Closed
kgar opened this issue Jul 25, 2022 · 1 comment
Closed

Remove correctInvalidMidWordBoldAndItalics() and related tests #3

kgar opened this issue Jul 25, 2022 · 1 comment
Labels
breaking-change A breaking change has been added, and a major version increment is needed on the next release. good first issue Good for newcomers

Comments

@kgar
Copy link
Owner

kgar commented Jul 25, 2022

The function correctInvalidMidWordBoldAndItalics() is part of this best practice from MarkdownGuide.

While this code works, it will cause some confusion for those who are not aware of the best practice and/or use markdown renderers that are not negatively impacted by not following the recommendation. It will also cause confusion when someone applies document- or entry-level options and sees those options ignored because of this best practice being forced on the final document.
@kgar kgar added good first issue Good for newcomers breaking-change A breaking change has been added, and a major version increment is needed on the next release. labels Jul 25, 2022
@kgar
Copy link
Owner Author

kgar commented Aug 26, 2023

fixed by #41

@kgar kgar closed this as completed Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change A breaking change has been added, and a major version increment is needed on the next release. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kgar