Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit tests #27

Closed
RJ-Clegg opened this issue Jan 6, 2019 · 3 comments
Closed

Add Unit tests #27

RJ-Clegg opened this issue Jan 6, 2019 · 3 comments

Comments

@RJ-Clegg
Copy link
Collaborator

RJ-Clegg commented Jan 6, 2019

Since this project is aimed at beginners and show casing latest iOS development techniques; we should also include unit testing with this project.

Thoughts?

@karmatt
Copy link

karmatt commented Jan 6, 2019

I definitely agree with this, especially since we are working with an outside API

@squarefrog
Copy link
Contributor

I tried to take a look at this today, however I hit a significant stumbling block. I've never used XcodeGen before, so I have no idea how I'd go about adding the testing targets for this.

Additionally, should there be a testing target for each library? E.g. Area51, CoreAPI, ImageService, or a single target that will allow tests to exercise all dependencies in one place?

Personally, I'd say there is benefit to both approaches, but I'd lean towards a single test target.

@RJ-Clegg
Copy link
Collaborator Author

RJ-Clegg commented Mar 2, 2019

Closing this as we have started using Unit Testing! 👍

@RJ-Clegg RJ-Clegg closed this as completed Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants