Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list of default subreddits #43

Open
kgellci opened this issue Feb 1, 2019 · 1 comment
Open

Add list of default subreddits #43

kgellci opened this issue Feb 1, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@kgellci
Copy link
Owner

kgellci commented Feb 1, 2019

I think Reddit has sunset their default subreddits list, but we can still pre-populate the side navigation with a defaults list. Can probably start by using this one: https://www.reddit.com/r/defaults/comments/61mgs9/list_of_default_subreddits_26_march_2017/

We can make the changes here for now: https://github.com/kgellci/Area51/blob/master/ListingService/Sources/Subreddit.swift

I plan on refactoring to make less static fo future use but fine to use for now.
@kgellci kgellci added good first issue Good for newcomers wontfix This will not be worked on and removed wontfix This will not be worked on labels Feb 1, 2019
@kgellci kgellci mentioned this issue Feb 13, 2019
Closed
@lucashoeft
Copy link
Contributor

screen shot 2019-02-15 at 13 00 45

To keep the UX similar to the website, I would like to have two sections in the table view for now. First with "All", "Popular" and "News" and the second with the list you posted except for news as it is already in the first section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgellci @lucashoeft