Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNAME record together with other data found in blockchain BREAKS entire dot bit zone! #4

Closed
Raegdan opened this issue May 9, 2013 · 1 comment

Comments

@Raegdan
Copy link

Raegdan commented May 9, 2013

Hi, and excuse me for my not so good English.

Today I made everything as shown in Readme installing my own dotbit DNS. One wrong domain found in NMC blockchain has CNAME record together with DNAME, while CNAME can't exist together with another records as Bind says. When this domain goes into Bind config it BREAKS entire .bit zone!

I wrote a little piece of code to handle this bug and ignore broken zones.

name.class.php

Find

foreach($records as $record=>$values) {
                    switch($record) {
                    case 'email':
                        #$this->bindZones[$fZone]['email'] = $values[0];
                        #$this->bindForwards[$fZone][] = str_pad($subdom, 15, ' ').$rec[$record].'"Email: '.$values[0].'"';
                        $other_exists = true;
                        break;

Insert before

                $cname_exists = $other_exists = false;
                foreach($records as $record=>$values) {
                    switch($record) {
                    case 'alias':
                        $cname_exists = true;
                        break;
                    case 'email':
                    case 'translate':
                    case 'ip':
                    case 'ip6':
                    case 'ns':
                        $other_exists = true;
                    }
                }

                if ($cname_exists && $other_exists)
                {
                    continue;
                }

After this fix everything's OK.

@khalahan
Copy link
Owner

Definitively fixed in commit 9e8e551 (fast fix was in commit 9a060f1)
Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants